-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cephfs-shell: use pkg_resources rather than packaging module #53710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are other instances:
$ source vstart_environment.sh && source venv/bin/activate && python3 ../src/tools/cephfs/shell/cephfs-shell
Traceback (most recent call last):
File "/home/jcollin/workspace/ceph/build/../src/tools/cephfs/shell/cephfs-shell", line 1848, in
read_shell_conf(shell, get_shell_conffile_path(args.config))
File "/home/jcollin/workspace/ceph/build/../src/tools/cephfs/shell/cephfs-shell", line 1704, in read_shell_conf
if version.parse(cmd2_version) >= version.parse("0.10.0"):
^^^^^^^
NameError: name 'version' is not defined. Did you mean: 'Version'?
oh, bother :/ sending a fix... |
`pkg_resources` is already being used by other py scripts. Fixes: https://tracker.ceph.com/issues/62739 Signed-off-by: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
jenkins test api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, though it's better move the doc changes to separate commit.
The doc change is a separate commit :) |
jenkins test api |
Fixes: https://tracker.ceph.com/issues/62739
Follow up on #53529
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows