Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: pg_interval_t::check_new_interval - for ec pool, should not rely on min_size to determine if the PG was active at the interval #5373

Merged
2 commits merged into from Sep 7, 2015

Conversation

Projects
None yet
2 participants
@ghost
Copy link

ghost commented Jul 28, 2015

Guang G Yang added some commits Jul 1, 2015

osd: Move IsRecoverablePredicate/IsReadablePredicate to osd_types.h
Signed-off-by: Guang Yang <yguang@yahoo-inc.com>
(cherry picked from commit 466b083)
osd: pg_interval_t::check_new_interval should not rely on pool.min_si…
…ze to determine if the PG was active

If the pool's min_size is set improperly, during peering, pg_interval_t::check_new_interval
might wrongly determine the PG's state and cause the PG to stuck at down+peering forever

Fixes: #12162
Signed-off-by: Guang Yang yguang@yahoo-inc.com
(cherry picked from commit 6849274)

Conflicts:
	src/osd/PG.cc
           because PG::start_peering_interval has an assert
           that is not found in hammer in the context
	src/test/osd/types.cc
           because include/stringify.h is not included by
           types.cc in hammer

@ghost ghost self-assigned this Jul 28, 2015

@ghost ghost added this to the hammer milestone Jul 28, 2015

@ghost ghost added bug fix core labels Jul 28, 2015

ghost pushed a commit that referenced this pull request Jul 29, 2015

Merge pull request #5373: pg_interval_t::check_new_interval - for ec …
…pool, should not rely on min_size to determine if the PG was active at the interval

Reviewed-by:
@ghost

This comment has been minimized.

Copy link
Author

ghost commented Aug 30, 2015

@athanatos does this backport look good to merge ? It passed a run of the hammer rados suite ( see http://tracker.ceph.com/issues/12701#rados for details ).

Please note that it did not cherry-pick cleanly and the details of the conflict resolution are at cd11b88. I believe they are not significant but it deserves verification.

ghost pushed a commit that referenced this pull request Aug 30, 2015

Merge pull request #5373: pg_interval_t::check_new_interval - for ec …
…pool, should not rely on min_size to determine if the PG was active at the interval

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Aug 30, 2015

Merge pull request #5373: pg_interval_t::check_new_interval - for ec …
…pool, should not rely on min_size to determine if the PG was active at the interval

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Aug 30, 2015

Merge pull request #5373: pg_interval_t::check_new_interval - for ec …
…pool, should not rely on min_size to determine if the PG was active at the interval

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Aug 31, 2015

Merge pull request #5373: pg_interval_t::check_new_interval - for ec …
…pool, should not rely on min_size to determine if the PG was active at the interval

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Sep 1, 2015

Merge pull request #5373: pg_interval_t::check_new_interval - for ec …
…pool, should not rely on min_size to determine if the PG was active at the interval

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Sep 2, 2015

Merge pull request #5373: pg_interval_t::check_new_interval - for ec …
…pool, should not rely on min_size to determine if the PG was active at the interval

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost

This comment has been minimized.

Copy link
Author

ghost commented Sep 6, 2015

@liewegas Sam's on vacation, would you mind taking a look at that backport ?

@ghost ghost assigned liewegas and unassigned ghost Sep 6, 2015

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Sep 7, 2015

👍

ghost pushed a commit that referenced this pull request Sep 7, 2015

Loic Dachary
Merge pull request #5373 from dachary/wip-12489-hammer
pg_interval_t::check_new_interval - for ec pool, should not rely on min_size to determine if the PG was active at the interval

Reviewed-by: Sage Weil <sage@redhat.com>

@ghost ghost merged commit 5ef999e into ceph:hammer Sep 7, 2015

@ghost ghost changed the title pg_interval_t::check_new_interval - for ec pool, should not rely on min_size to determine if the PG was active at the interval osd: pg_interval_t::check_new_interval - for ec pool, should not rely on min_size to determine if the PG was active at the interval Sep 13, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.