-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qa: upgrade only from N-2, N-1 releases #53734
Conversation
4a8334d
to
a090a73
Compare
@dparmar18 https://pulpito.ceph.com/vshankar-2023-11-06_09:35:56-fs:upgrade-wip-vshankar-testing-20231106.073650-testing-default-smithi/ PRs in test - https://github.com/ceph/ceph/pulls?q=is%3Aopen+label%3Acephfs+label%3Awip-vshankar-testing The (one) failure is the one you mentioned in slack:
|
Fixes: https://tracker.ceph.com/issues/62953 Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
Fixes: https://tracker.ceph.com/issues/62953 Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
|
@dparmar18 This crash is due to absence of PR #53340 in reef. The MDS will encode the following two fields in the MDSMap with version=17:
But the client running reef version, will decode like:
and then the final |
Right, but we found an issue which eventually would have been resolved :) |
Short summary of the changes made in this PR:
|
dir tree before this patch:
tree after this patch:
|
@dparmar18 Could you explain (in the commit message) why there is a "topology" change in the way the yamls are structured? IIUC, there are changes that auto-select branch names, but it would help to be clear in the commit message. |
the cluster should never be upgraded in
the new ops yaml in |
@vshankar the explanation is there in the commit already, do let me know if its not enough |
* start testing new_ops and stress_tests with both the drivers(i.e. fuse and kclient) therefore moved 0-clients/ from tasks/3-workload/new_ops/ to tasks/ and renamed it to 2-clients/ * since new_ops/ and stress_tests/ now share the common upgrade yaml, moved the tests yamls(in stress_tests/1-tests) directly under 3-workload/stress_tests/ * renamed 1-client-sanity.yaml in new_ops/ to newops.yaml Fixes: https://tracker.ceph.com/issues/62953 Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
I see you updated the commit message. Nice clear description now - appreciate it @dparmar18 |
Putting this to test since the fix has been merged. |
* refs/pull/53734/head: qa: refactor client upgrade yamls and other minor touchups qa/upgrade/nofs: upgrade pacific->reef qa/upgrade/upgraded_client: upgrade nautilus->pacific and pacific->reef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows