pacific: rgw: add radosgw-admin bucket check olh/unlinked commands #53808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds commands to radosgw-admin for checking for and fixing leftover entries in the bucket index (and associated RADOS objects). Fixes: https://tracker.ceph.com/issues/62075 Signed-off-by: Cory Snyder <csnyder@1111systems.com> (cherry picked from commit 9b2042a) Conflicts: src/rgw/driver/rados/rgw_bucket.cc src/rgw/driver/rados/rgw_bucket.h src/rgw/driver/rados/rgw_rados.cc src/rgw/rgw_admin.cc Cherry-pick notes: - conflicts due to rados files being moved into driver directory - conflicts due to rename of rados classes
… bugs Signed-off-by: Cory Snyder <csnyder@1111systems.com> (cherry picked from commit b79dcf6)
…k index Fixes: https://tracker.ceph.com/issues/62760 Signed-off-by: Cory Snyder <csnyder@1111systems.com> (cherry picked from commit 152aadb) Conflicts: src/cls/rgw/cls_rgw.cc Cherry-pick notes: - Some function ordering changed
If a call to bucket_index_link_olh or bucket_index_unlink_instance fails, its associated pending xattr may have prevented the olh object from being removed by another thread. We should do a best effort cleanup attempt for this case by calling update_olh before returning an error to the caller. Signed-off-by: Cory Snyder <csnyder@1111systems.com> (cherry picked from commit 570adec) Conflicts: src/rgw/driver/rados/rgw_rados.cc Cherry-pick notes: - Conflicts due to rgw_rados file being moved into driver dir in later versions
…--check-objects flag Printing all index entries can be very time consuming for large buckets and the inability to switch this behavior off makes it cumbersome to use the command for fixing bucket stats. This was also preventing the command from outputting recalculated bucket stats when the --fix flag wasn't specified. Signed-off-by: Cory Snyder <csnyder@1111systems.com> (cherry picked from commit 6b057fe) Conflicts: src/rgw/driver/rados/rgw_bucket.cc Cherry-pick notes: - Conflicts due to rgw_bucket.cc moved into driver dir in later versions
…bucket Reproduces a regression where radosgw-admin bucket check incorrectly counts objects that started as unversioned and later transitioned to versioned. Signed-off-by: Cory Snyder <csnyder@1111systems.com> (cherry picked from commit 340522f)
Fixes a regression with radosgw-admin bucket check stat calculation and bucket reshard stat calculation when there are objects that have transitioned from unversioned to versioned. The bug was introduced in 152aadb. Signed-off-by: Cory Snyder <csnyder@1111systems.com> (cherry picked from commit 4728daa)
The bucket index check admin API was previously returning invalid JSON. Signed-off-by: Cory Snyder <csnyder@1111systems.com> (cherry picked from commit 32fb6a1)
cbodley
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/62945
backport of #52576
parent tracker: https://tracker.ceph.com/issues/62075
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh