reef: osd: fix: slow scheduling when item_cost is large #53861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use the iops and bandwidth tested by `ceph tell osd.0 bench 10737418240 204800 204800 100` to verify the QoS function. iops was 400 and bandwidth was 80MiB/s. When osd_mclock_scheduler_client_lim is set to 1, the sequential write bandwidth is only half of the capacity. Therefore, we believe that it should not unconditionally increase osd_bandwidth_cost_per_io for each IO, but take the maximum of the two. Fixes: https://tracker.ceph.com/issues/62812 co-author: yanghonggang <yanghonggang_yewu@cmss.chinamobile.com> co-author: zhangjianwei <zhangjianwei2_yewu@cmss.chinamobile.com> Signed-off-by: Jrchyang Yu <yuzhiqiang_yewu@cmss.chinamobile.com> (cherry picked from commit 65ebf2d)
sseshasa
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/63125
backport of #53417
parent tracker: https://tracker.ceph.com/issues/62812
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh