Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qa: lower mds_session_metadata_threshold for tests #53873

Merged
merged 2 commits into from
Oct 9, 2023
Merged

qa: lower mds_session_metadata_threshold for tests #53873

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92200d9
qa: lower mds_session_metadata_threshold for tests
vshankar Oct 7, 2023
5856a1e
qa: typo fix when checking for perf counter - s/md_thresh_evicted/mdt…
vshankar Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 6 additions & 7 deletions qa/tasks/cephfs/test_client_limits.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,20 +272,19 @@ def test_client_blocklisted_oldest_tid(self):
# Wait for the health warnings. Assume mds can handle 10 request per second at least
self.wait_for_health("MDS_CLIENT_OLDEST_TID", max_requests // 10, check_in_detail=str(self.mount_a.client_id))

# why a multiplier of 20, you may ask - I arrieved at this from some debugs
# that I put when testing the fix in a vstart cluster where its a ratio of
# encoded session information to the number of completed requests.
self.config_set('mds', 'mds_session_metadata_threshold', max_requests*20);
# set the threshold low so that it has a high probability of
# hitting.
self.config_set('mds', 'mds_session_metadata_threshold', 5000);
lxbsz marked this conversation as resolved.
Show resolved Hide resolved

# Create a few more files synchronously. This would hit the session metadata threshold
# Create lot many files synchronously. This would hit the session metadata threshold
# causing the client to get blocklisted.
with self.assertRaises(CommandFailedError):
self.mount_a.create_n_files("testdir/file2", 20, True)
self.mount_a.create_n_files("testdir/file2", 100000, True)
lxbsz marked this conversation as resolved.
Show resolved Hide resolved

self.mds_cluster.is_addr_blocklisted(self.mount_a.get_global_addr())
# the mds should bump up the relevant perf counter
pd = self.perf_dump()
self.assertGreater(pd['mds_sessions']['md_thresh_evicted'], 0)
self.assertGreater(pd['mds_sessions']['mdthresh_evicted'], 0)

# reset the config
self.config_set('client', 'client inject fixed oldest tid', 'false')
Expand Down