reef: mon/ConfigMonitor: Show localized name in "config dump --format json" output #53888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… output The "ceph config dump" command without the json formatted output shows the localized option names and their values. An example of a normalized vs localized option is shown below: Normalized: mgr/dashboard/ssl_server_port (maintaned within Option struct) Localized: mgr/dashboard/x/ssl_server_port (maintained in mon store) But the "ceph config dump --format json*" output showed the normalized option names which was not consistent with the "config dump" output. The output of the command along with variations for pretty printing must show the same content. This commit introduces a new member within the ConfigMap's MaskedOption struct called "localized_name". This is initialized to the localized name as part of ConfigMonitor::load_config() method. The MaskedOption::dump() used for the json formatting is modified to display the localized_name instead of the normalized name. Fixes: https://tracker.ceph.com/issues/62379 Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com> (cherry picked from commit 3821722)
…utput. Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com> (cherry picked from commit 401b30f) Conflicts: PendingReleaseNotes - Remove unrelated release note related to Cephfs
sseshasa
force-pushed
the
wip-63128-reef
branch
from
01bcfbe
to
4f1615e
Compare
|
jenkins test make check |
sseshasa
requested review from
rzarzynski and
ljflores
and removed request for
a team
|
@rzarzynski Can you please review this backport? |
rzarzynski
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/63128
backport of #52906
parent tracker: https://tracker.ceph.com/issues/62379
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh