reef: librbd: kick ExclusiveLock state machine stalled waiting for lock from reacquire_lock() #53919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... that is stalled waiting for lock. Do this when trying to reacquire lock in the ImageWatcher's rewatch mechanism. This would enable the ExclusiveLock state machine to propagate the blocklist error to the caller trying to perform an image operation requiring an exclusive lock. Previous attempt, e66db76, to fix the hang due to exclusive lock acquisiton (stuck waiting for lock) racing with client blocklisting did not always work. e66db76 kickstarted the ExclusiveLock state machine when the ImageWatcher tried to schedule a exclusive lock request and the blocklisting was detected. However, there is a short window between a watch getting deregistered and client blocklisting getting detected as part of rewatching. If hit when trying to schedule a lock request, the ExclusiveLock state machine wasn't kickstarted, blocklist error wasn't propagated, and the hang resurfaced. A more robust approach is taken to resume the ExclusiveLock state machine stuck waiting for lock during client blocklisting. Whenever a client's ImageWatcher loses connection to the cluster, as it happens during blocklising, the ImageWatcher initiates a mechanism to rewatch the image and tries to reacquire the lock. Piggyback on this rewatch mechanism that gets triggered during client blocklisting. And when trying to reacquire the lock, kickstart the ExclusiveLock state machine stalled waiting for lock (STATE_WAITING_FOR_LOCK). Fixes: https://tracker.ceph.com/issues/63009 Signed-off-by: Ramana Raja <rraja@redhat.com> (cherry picked from commit 18b0185)
idryomov
approved these changes
Oct 10, 2023
|
jenkins test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/63156
backport of #53829
parent tracker: https://tracker.ceph.com/issues/63009
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh