Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reef: crimson/os/seastore: realize lazy read in split overwrite with overwrite refactor #53951

Merged
merged 10 commits into from Oct 17, 2023
Merged

reef: crimson/os/seastore: realize lazy read in split overwrite with overwrite refactor #53951

merged 10 commits into from Oct 17, 2023

Conversation

Matan-B
Copy link
Contributor

@Matan-B Matan-B commented Oct 11, 2023

backport of #51179

this backport was staged using crimson-backport.sh which is based on ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

See: https://gist.github.com/Matan-B/3366024c130634942d0b1227112663e1

@aisakaki @Matan-B
crimson/os/seastore: let CachedExtent::ptr optional
44365c4 
separate buffer length and data length, since no buffer extent is allowed

Signed-off-by: Xinyu Huang <xinyu.huang@intel.com>
(cherry picked from commit 7cb44d3)
@aisakaki @Matan-B
crimson/os/seastore: support no data extent in read path
c847e01 
Signed-off-by: Xinyu Huang <xinyu.huang@intel.com>
(cherry picked from commit f19de7c)
@aisakaki @Matan-B
crimson/os/seastore/transaction_manager: implement alloc_remapped_extent
f8d93e7 
Signed-off-by: Xinyu Huang <xinyu.huang@intel.com>
(cherry picked from commit cf6e46e)
@aisakaki @Matan-B
crimson/os/seastore/transaction_manager: implement remap_pin
642f55e 
Signed-off-by: Xinyu Huang <xinyu.huang@intel.com>
(cherry picked from commit 55d33b6)
@aisakaki @Matan-B
crimson/os/seastore: realize lazy read in split overwrite with overwr…
233f6c5 
…ite refactor

Signed-off-by: Xinyu Huang <xinyu.huang@intel.com>
(cherry picked from commit 5d00ec0)
@aisakaki @Matan-B
crimson/os/seastore: deepcopy the buffer of exist clean extent when d…
6448732 
…uplicate_for_write

Beacuse exist clean extent shares buffer with original clean extent.

Signed-off-by: Xinyu Huang <xinyu.huang@intel.com>
(cherry picked from commit 026066a)
@aisakaki @Matan-B
crimson/os/seastore: check if length exist in mark_space_used and mar…
b47fad7 
…k_space_free

to avoid misuse of buffer length and data length when there is a no actual data extent

Signed-off-by: Xinyu Huang <xinyu.huang@intel.com>
(cherry picked from commit dc4a23c)
@aisakaki @Matan-B
test/crimson/seastore: add test for TransactionManager::remap_pin
dc4624b 
Signed-off-by: Xinyu Huang <xinyu.huang@intel.com>
(cherry picked from commit b5931d2)
@aisakaki @Matan-B
test/crimson/seastore: test overwrite pin
3d8f3bf 
Signed-off-by: Xinyu Huang <xinyu.huang@intel.com>
(cherry picked from commit efd3cdc)
@aisakaki @Matan-B
test/crimson/seastore: test if lazy read work correctly
5484020 
Signed-off-by: Xinyu Huang <xinyu.huang@intel.com>
(cherry picked from commit 9d973ef)
@Matan-B Matan-B requested a review from a team as a code owner October 11, 2023 11:41
@Matan-B Matan-B added this to the reef milestone Oct 11, 2023
@Matan-B
Copy link
Contributor Author

Matan-B commented Oct 17, 2023

jenkins test make check

@Matan-B
Copy link
Contributor Author

Matan-B commented Oct 17, 2023

https://pulpito.ceph.com/matan-2023-10-15_12:42:04-crimson-rados-wip-matanb-crimson-reef-backports-12.10-all-distro-crimson-smithi/

@Matan-B Matan-B merged commit 9bf09be into ceph:reef Oct 17, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athanatos athanatos athanatos approved these changes

Assignees
No one assigned
Labels
crimson backport reef crimson tests
Projects
None yet
Milestone
reef
3 participants
@Matan-B @athanatos @aisakaki