reef: crimson/os/seastore/journal/cbj: generalize scan_valid_records() #53961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_records() Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com> (cherry picked from commit 22c7478)
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com> (cherry picked from commit a580e51)
…at written records are correct The cbj would replay invalid records if the same write pattern (mkfs -> write -> mkfs -> write) repeats. On the second mkfs(), current cbj wrongly recognizes the old records are valid beceause they have correct seq. number at appropriate offset even though the records are expired. To solve this, this commit introduces random value to identify the journal during mkfs() Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com> (cherry picked from commit 942ea64)
…written after rolling or not Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com> (cherry picked from commit a10f285)
…_validate_data Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com> (cherry picked from commit 15ae64c)
… at once before rolling Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com> Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com> (cherry picked from commit ef1a6a9)
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com> (cherry picked from commit 39ea5ad)
athanatos
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #52128
this backport was staged using crimson-backport.sh which is based on ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh
See: https://gist.github.com/Matan-B/3366024c130634942d0b1227112663e1