reef: pybind/rbd: don't produce info on errors in aio_mirror_image_get_info() #54055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check completion return value before attemting to decode c_info. Otherwise we are guaranteed to access invalid memory in decode_cstr() while trying to compute global_id string length when the client is blocklisted for example. Fixes: https://tracker.ceph.com/issues/63028 Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit a81bd2d)
Make it clear that mirror mode, mirror info and snap ID can be None if the respective operation fails. Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit 01fff6a)
ajarr
approved these changes
Oct 17, 2023
trociny
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/63228
backport of #54002
parent tracker: https://tracker.ceph.com/issues/63028