pacific: client: readdir_r_cb: get rstat for dir only if using rbytes for size #54179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `client_dirsize_rbytes` is off, there should be no need for getting rstat on readdir operations. This fixes performance when `client_dirsize_rbytes` is off after ceph#38222. Fixes: https://tracker.ceph.com/issues/61999 Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com> (cherry picked from commit 69decab)
kclient also has this option, and is unchangeable unless remounted. Let's keep parity with kclient. Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com> (cherry picked from commit 05a48a4)
|
Not a blocker/urgent for last pacific relase - closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/62003
backport of #46960
parent tracker: https://tracker.ceph.com/issues/61999
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh