Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pacific: client: always refresh mds feature bits on session open #54245

Merged
merged 1 commit into from
Nov 22, 2023
Merged

pacific: client: always refresh mds feature bits on session open #54245

merged 1 commit into from
Nov 22, 2023

Conversation

vshankar
Copy link
Contributor

backport tracker: https://tracker.ceph.com/issues/63283

backport of #54030
parent tracker: https://tracker.ceph.com/issues/63188

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

@vshankar vshankar added this to the pacific milestone Oct 30, 2023
@vshankar vshankar added the cephfs Ceph File System label Oct 30, 2023
@batrick batrick modified the milestones: pacific, v16.2.15 Nov 8, 2023
@yuriw
Copy link
Contributor

yuriw commented Nov 8, 2023

@vshankar I suspect this PR broke the build

https://jenkins.ceph.com/job/ceph-dev-new-build/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=centos8,DIST=centos8,MACHINE_SIZE=gigantic/73979//consoleFull

[ 56%] Building CXX object src/librbd/CMakeFiles/rbd_internal.dir/TrashWatcher.cc.o
/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/16.2.14-139-gfd7a66ad/rpm/el8/BUILD/ceph-16.2.14-139-gfd7a66ad/src/client/Client.cc: In member function ‘void Client::handle_client_session(MConstRef&)’:
/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/16.2.14-139-gfd7a66ad/rpm/el8/BUILD/ceph-16.2.14-139-gfd7a66ad/src/client/Client.cc:2355:30: error: request for member ‘get’ in ‘session’, which is of pointer type ‘MetaSession*’ (maybe you meant to use ‘->’ ?)
reinit_mds_features(session.get(), m);
^~~
/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/16.2.14-139-gfd7a66ad/rpm/el8/BUILD/ceph-16.2.14-139-gfd7a66ad/src/client/Client.cc:2374:35: error: request for member ‘get’ in ‘session’, which is of pointer type ‘MetaSession*’ (maybe you meant to use ‘->’ ?)
reinit_mds_features(session.get(), m);
^~~

@vshankar
client: always refresh mds feature bits on session open
798cb2c 
Fixes: http://tracker.ceph.com/issues/63188
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 167fdd2)

 Conflicts:
	src/client/Client.cc

In pacific, the client would close the mds session if it has missing
features - adjust the code due to that. Also adjust for `session`
variable in Client::handle_client_session() as in pacific its of
type MetaSession* rather than MetaSesssionRef.
@vshankar
Copy link
Contributor Author

vshankar commented Nov 9, 2023

fixed and updated.

@yuriw this is ready for testing.

rishabh-d-dave
rishabh-d-dave approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CephFS approved - https://tracker.ceph.com/projects/cephfs/wiki/Pacific#22-Nov-2023

@yuriw yuriw merged commit 6e93de6 into ceph:pacific Nov 22, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-d-dave rishabh-d-dave rishabh-d-dave approved these changes

Assignees
No one assigned
Labels
cephfs Ceph File System wip-yuri4-testing
Projects
None yet
Milestone
v16.2.15
4 participants
@vshankar @yuriw @rishabh-d-dave @batrick