pacific: mon: fix mds metadata lost in one case. #54318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In most cases, peon's pending_metadata is inconsistent with mon's db. When a peon turns into leader, and at the same time a active mds stops, the new leader may flush wrong mds metadata into db. So we meed to update mds metadata from db at every fsmap change. This phenomenon can be reproduce like this: A Cluster with 3 mon and 3 mds (one active, other two standby), 6 osd. step 1. stop two standby mds; step 2. restart all mon; (make pending_medata consistent with db) step 3. start other two mds step 4. stop leader mon step 5. run "ceph mds metadata" command to check mds metadata step 6. stop active mds step 7. run "ceph mds metadata" command to check mds metadata again In step 7, we would find mds metadata lost. Fixes: https://tracker.ceph.com/issues/63166 Signed-off-by: shimin <shimin@kuaishou.com> (cherry picked from commit 56cbf3f)
rishabh-d-dave
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
CephFS approved - https://tracker.ceph.com/projects/cephfs/wiki/Pacific#22-Nov-2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/63414
backport of #53883
parent tracker: https://tracker.ceph.com/issues/63166
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh