common/Thread: pthread_attr_destroy(thread_attr) when done with it #5433
Conversation
qiankunzheng
changed the title
qiankunzheng
changed the title
|
@zqkkqz, could you please prefix the title of your commit message with "common/Thread: ". and make it more brief? for example:
and it would be ideal if you can file a ticket in http://tracker.ceph.com, and connect this pull request to it using the notation of
you can find more examples using thanks. |
|
note: this fix also applies to hammer and firefly |
|
BTW, you might need to rebase your change against master after #5337 is merged. |
|
the failed bot run on ubuntu is fixed in master. see #5432 /usr/bin/ld: ./.libs/libkrbd.a(buffer.o): undefined reference to symbol 'pthread_rwlock_wrlock@@GLIBC_2.2.5' //lib/x86_64-linux-gnu/libpthread.so.0: error adding symbols: DSO missing from command line |
qiankunzheng
changed the title
|
@tchaikov |
|
@zqkkqz could you rebase your change against master again, to resolve the conflicts? |
When a thread attributes object is no longer required, it should be destroyed using the pthread_attr_destroy() function. Destroying a thread attributes object has no effect on threads that were created using that object. Fixes: ceph#12570 Signed-off-by: zqkqkz zheng.qiankun@h3c.com
|
|
|
@tchaikov Hi, since review has been done, so when merge can be done ? |
|
@cxwshawn sorry for the latency. once it is confirmed by our test suites. it's good to merge. |
common/Thread: pthread_attr_destroy(thread_attr) when done with it Reviewed-by: Kefu Chai <kchai@redhat.com>
When a thread attributes object is no longer required, it should be destroyed using the
pthread_attr_destroy() function. Destroying a thread attributes object has no effect on threads that were created using that object.
Fixes: #12570
Signed-off-by: zqkqkz zheng.qiankun@h3c.com