Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pacific: MClientRequest: properly handle ceph_mds_request_head_legacy for ext_num_retry, ext_num_fwd, owner_uid, owner_gid #54410

Merged
merged 1 commit into from Nov 22, 2023

Conversation

mihalicyn
Copy link
Contributor

In this packport ("MClientRequest: handle owner_uid and owner_gid from ceph_mds_request_head_legacy") commit was dropped because it is only relevant to the changes from #53137 pull request. But we decided not to take this change into the final pacific release

backport tracker: https://tracker.ceph.com/issues/63478


backport of #54149
parent tracker: https://tracker.ceph.com/issues/63288

…quest_head_legacy

When a client is too old and uses struct ceph_mds_request_head_legacy we must
fill new ext_num_retry and ext_num_fwd fields from an old num_retry and num_fwd.

Fixes: ceph#45669
Fixes: https://tracker.ceph.com/issues/63288
Fixes: commit cbd7e30 ("ceph_fs.h: add 32 bits extended num_retry and num_fwd support")

Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
(cherry picked from commit 43f32a4)
@github-actions github-actions bot added this to the pacific milestone Nov 8, 2023
@mihalicyn
Copy link
Contributor Author

cc @vshankar

@batrick batrick added cephfs Ceph File System needs-qa labels Nov 8, 2023
@batrick batrick modified the milestones: pacific, v16.2.15 Nov 8, 2023
@rishabh-d-dave
Copy link
Contributor

@mihalicyn This PR is a partial backport of PR #54149. 2nd commit (a70a70f) from that PR is missing. I couldn't find an explanation for this in the commit message or on the tracker ticket. Can you please backport it too or, for future reference, add a note explaining why it wasn't backported?

cc @vshankar

@mihalicyn
Copy link
Contributor Author

@mihalicyn This PR is a partial backport of PR #54149. 2nd commit (a70a70f) from that PR is missing. I couldn't find an explanation for this in the commit message or on the tracker ticket. Can you please backport it too or, for future reference, add a note explaining why it wasn't backported?

Sure, have added to the backport tracker.

And I already have this in the first message in this PR:

In this packport ("MClientRequest: handle owner_uid and owner_gid from ceph_mds_request_head_legacy") commit was dropped because it is only relevant to the changes from #53137 pull request. But we decided not to take this change into the final pacific release

Copy link
Contributor

@rishabh-d-dave rishabh-d-dave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuriw yuriw merged commit 3ed2cfb into ceph:pacific Nov 22, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants