Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph-volume: fix a regression in raw list #54514

Merged
merged 1 commit into from Nov 16, 2023
Merged

ceph-volume: fix a regression in raw list #54514

merged 1 commit into from Nov 16, 2023

Conversation

guits
Copy link
Contributor

@guits guits commented Nov 15, 2023

'ceph-volume raw list' is broken for a specific use case (rook).

rook copies devices from /dev/ to /mnt for specific/internal needs.

when ceph-volume raw list is passed a device from /mnt then ceph-volume ignores it and return an empty dict.
That prevent rook from creating OSDs properly.

https://tracker.ceph.com/issues/63545

@guits guits requested a review from a team as a code owner November 15, 2023 15:32
@guits guits mentioned this pull request Nov 15, 2023
Open
@guits guits marked this pull request as draft November 15, 2023 15:47
@guits
ceph-volume: fix a regression in raw list
e67dce7 
'ceph-volume raw list' is broken for a specific use case (rook).

rook copies devices from /dev/ to /mnt for specific/internal needs.

when ceph-volume raw list is passed a device from /mnt then
ceph-volume ignores it and return an empty dict.
That prevent rook from creating OSDs properly.

https://tracker.ceph.com/issues/63545

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
@guits guits marked this pull request as ready for review November 15, 2023 17:22
@travisn
Copy link
Member

travisn commented Nov 15, 2023

The Rook PVC scenarios where we copy to /mnt are working on the latest-reef-devel tag for all the CI tests as seen in rook/rook#13203.
@rkachach Please include your repro steps so we can understand if it is your environment, if this is an uncommon case, or if it is more common. The scope of the impact seems small since at least this issue was not seen in the scenarios tested by the CI.

@travisn
Copy link
Member

travisn commented Nov 15, 2023

The Rook PVC scenarios where we copy to /mnt are working on the latest-reef-devel tag for all the CI tests as seen in rook/rook#13203. @rkachach Please include your repro steps so we can understand if it is your environment, if this is an uncommon case, or if it is more common. The scope of the impact seems small since at least this issue was not seen in the scenarios tested by the CI.

I realized the tests were only partially using the latest-reef-devel tag, and the critical tests were not using that tag. :(
I reopened the Rook PR rook/rook#13203 to test the OSDs on PVCs with the latest-reef-devel tag, and now I see that all the PVC-based tests are failing, except the encrypted OSD tests. That is expected since the encrypted OSDs use lvm mode, which is not affected by this issue. So this is a blocker for Rook scenarios, thanks for catching.

@guits
Copy link
Contributor Author

guits commented Nov 15, 2023

https://github.com/rook/rook/actions/runs/6882524258?pr=13215

@travisn
Copy link
Member

travisn commented Nov 15, 2023

https://github.com/rook/rook/actions/runs/6882524258?pr=13215

Hooray, the tests are passing with this fix!

@guits
Copy link
Contributor Author

guits commented Nov 15, 2023 •
edited

https://pulpito.ceph.com/gabrioux-2023-11-15_22:09:17-orch:cephadm-wip-guits-fix-cv-raw-list-distro-default-smithi/
https://pulpito.ceph.com/gabrioux-2023-11-16_06:31:01-orch:cephadm-wip-guits-fix-cv-raw-list-distro-default-smithi/
https://pulpito.ceph.com/gabrioux-2023-11-16_07:44:44-orch:cephadm-wip-guits-fix-cv-raw-list-distro-default-smithi/

@rkachach
Copy link
Contributor

rkachach commented Nov 15, 2023 •
edited

The Rook PVC scenarios where we copy to /mnt are working on the latest-reef-devel tag for all the CI tests as seen in rook/rook#13203. @rkachach Please include your repro steps so we can understand if it is your environment, if this is an uncommon case, or if it is more common. The scope of the impact seems small since at least this issue was not seen in the scenarios tested by the CI.

I realized the tests were only partially using the latest-reef-devel tag, and the critical tests were not using that tag. :( I reopened the Rook PR rook/rook#13203 to test the OSDs on PVCs with the latest-reef-devel tag, and now I see that all the PVC-based tests are failing, except the encrypted OSD tests. That is expected since the encrypted OSDs use lvm mode, which is not affected by this issue. So this is a blocker for Rook scenarios, thanks for catching.

@travisn that makes more sense as in fact my environment doesn't have anything special. I was just trying to create a cluster with OSDs backed by local pvcs.

asm0deuz
asm0deuz approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@asm0deuz asm0deuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guits guits merged commit 3657ad5 into ceph:main Nov 16, 2023
10 of 11 checks passed
@guits guits deleted the fix-cv-raw-list branch November 16, 2023 09:29
This was referenced Nov 16, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asm0deuz asm0deuz asm0deuz approved these changes

Assignees
No one assigned
Labels
ceph-volume
Projects
None yet
Milestone
No milestone
4 participants
@guits @travisn @rkachach @asm0deuz