Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgw/notifications: cleanup all coroutines after sending the notification #54528

Merged
merged 1 commit into from
Nov 19, 2023
Merged

rgw/notifications: cleanup all coroutines after sending the notification #54528

merged 1 commit into from
Nov 19, 2023

Conversation

yuvalif
Copy link
Contributor

@yuvalif yuvalif commented Nov 16, 2023 •
edited
Loading

this is fixing a regression from: 6b6592f

Fixes: https://tracker.ceph.com/issues/63580

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@yuvalif yuvalif requested a review from a team as a code owner November 16, 2023 15:50
@github-actions github-actions bot added the rgw label Nov 16, 2023
@yuvalif
rgw/notifications: cleanup all coroutines after sending the notification
63e1489 
this is fixing a regression from: 6b6592f

Fixes: https://tracker.ceph.com/issues/63580

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
@yuvalif
Copy link
Contributor Author

yuvalif commented Nov 19, 2023

teuthology run: http://qa-proxy.ceph.com/teuthology/yuvalif-2023-11-17_09:38:44-rgw:notifications-wip-yuval-63532-distro-default-smithi/7461380/
has a know failure: https://tracker.ceph.com/issues/62136

@yuvalif yuvalif removed the needs-qa label Nov 19, 2023
@yuvalif
Copy link
Contributor Author

yuvalif commented Nov 19, 2023

jenkins test api

@yuvalif yuvalif merged commit 329e2a1 into ceph:main Nov 19, 2023
12 checks passed
@yuvalif
Copy link
Contributor Author

yuvalif commented Nov 19, 2023

passing teuthology: https://pulpito.ceph.com/yuvalif-2023-11-19_17:58:18-rgw:notifications-wip-yuval-63580-debug-distro-default-smithi/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbodley cbodley cbodley approved these changes

Assignees
No one assigned
Labels
rgw
Projects
None yet
Milestone
No milestone
2 participants
@yuvalif @cbodley