pacific: common: intrusive_lru destructor add #54558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Maredia <amaredia@redhat.com> (cherry picked from commit b3b28a4)
values created during inserts that are unreferenced are not deleted because evict() does not delete values unless set.size() > lru_target_size. For example, this condition is not met if the number of entries in the intrusive_lru are less than or equal to lru_target_size at the time of the intrusive_lru's destruction. Memory leaks due to the above scenario can be reproduced if this commit is removed and unittest_intrusive_lru is run under valgrind. ex: valgrind --tool=memcheck --leak-check=yes ./bin/unittest_intrusive_lru Signed-off-by: Ali Maredia <amaredia@redhat.com> (cherry picked from commit abd84ad)
k0ste
force-pushed
the
wip-57794-pacific
branch
from
d1e0608
to
65b22e8
Compare
|
If this is a must for 16.2.15, please add it to https://github.com/ceph/ceph/milestone/17 since Pacific is going EOL. |
|
@k0ste ^ |
rzarzynski
approved these changes
Jan 10, 2024
Only developers can edit labels and milestones, I'm not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/57794
backport of #48128
parent tracker: https://tracker.ceph.com/issues/57573
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh