rgw: add headers to guide cache update in 304 response #54587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
… get Fixes: https://tracker.ceph.com/issues/45736 Signed-off-by: Ilsoo Byun <ilsoobyun@linecorp.com>
when `ReadOp::prepare()` fails with `-ERR_NOT_MODIFIED`, it succeeded in reading the head object for mtime and attrs like etag. make those attrs available to RGWGetObj so we can still send ETag and other cache-related response headers Fixes: https://tracker.ceph.com/issues/45736 Signed-off-by: Casey Bodley <cbodley@redhat.com>
|
passed qa in https://pulpito.ceph.com/cbodley-2024-01-04_20:15:15-rgw-wip-cbodley-testing-distro-default-smithi/, which included test from ceph/s3-tests#533 |
yuvalif
reviewed
Jan 8, 2024
| version_id = s->object->get_instance(); | ||
| s->obj_size = s->object->get_obj_size(); | ||
| attrs = s->object->get_attrs(); | ||
| multipart_parts_count = read_op->params.parts_count; | ||
| if (op_ret < 0) |
There was a problem hiding this comment.
what about other error codes? is it safe to get attributes, size etc, if the head read failed for some other reason?
maybe wrap with if (op_ret == 0 || op_ret == -ERR_NOT_MODIFIED) ?
There was a problem hiding this comment.
the variables are safe to copy on a read error, they'd just have their default values
yuvalif
approved these changes
Jan 8, 2024
|
tyvm @yuvalif |
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revives the fix from #35284
needed an additional change to
RGWGetObj::execute()to save the objectattrswhenread_op->prepare()returns an error (like-ERR_NOT_MODIFIEDin this case)Fixes: https://tracker.ceph.com/issues/45736
test case in ceph/s3-tests#533
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e