Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/tasks/cephfs/test_misc: switch duration to timeout #54683

Merged
merged 2 commits into from Jan 29, 2024

Conversation

lxbsz
Copy link
Member

@lxbsz lxbsz commented Nov 28, 2023

The duration is impresise and sometimes will give a false alarm
just in case the shell command itself is issued late.

https://tracker.ceph.com/issues/63587

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

The duration is impresise and sometimes will give a false alarm
just in case the shell command itself is issued late.

https://tracker.ceph.com/issues/63587
Signed-off-by: Xiubo Li <xiubli@redhat.com>
@lxbsz lxbsz requested a review from a team November 28, 2023 03:07
@github-actions github-actions bot added cephfs Ceph File System tests labels Nov 28, 2023
vshankar added a commit to vshankar/ceph that referenced this pull request Jan 25, 2024
* refs/pull/54683/head:
	qa/tasks/cephfs/test_misc: switch duration to timeout
	qa/tasks/cephfs/test_misc: fix the incorrect comments

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vshankar vshankar merged commit 527b465 into ceph:main Jan 29, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cephfs Ceph File System tests
Projects
None yet
4 participants