rbd: support size suffixes for size-based options #5481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jdurgin , I have checked strict_sistrtoll function: and it returns only value of option if user will not specify size suffix with the value which will be bytes only as these options default value is bytes so we don't need to handle any specific case for these options. |
| "stripe_count": 8, | ||
| "stripe_unit": 1048576 | ||
| } | ||
| $ rbd rm test --no-progress |
There was a problem hiding this comment.
Can you include a test case with non-byte units too?
There was a problem hiding this comment.
Thanks Sage for review , sure I will add it!
This patch will provide support for size suffixes for below given options: --stripe-unit <size in B/K/M> --io-size <size in B/K/M/G/T> --io-total <size in B/K/M/G/T> Signed-off-by: Vikhyat Umrao <vumrao@redhat.com>
vumrao
force-pushed
the
wip-vumrao-12111
branch
from
c58a5d6
to
cd4ac1c
Compare
|
Please ignore the bot failure on Ubuntu, it is a false negative that has been fixed. |
|
@dachary thanks ! |
|
@jdurgin Thanks Josh ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will provide support for size suffixes for
below given options:
--stripe-unit [size in B/K/M]
--io-size [size in B/K/M/G/T]
--io-total [size in B/K/M/G/T]
Signed-off-by: Vikhyat Umrao vumrao@redhat.com