src/mon/OSDMonitor.cc: more descriptive loggings for crc mismatch #54890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When mons are running different versions, e.g., during upgrades, we sometimes will encounter a crc mismatch between the crc that is generated from the leader MON (version n+1) and the peon MON (version). Which will later then gets resolved when all the MONs are at version n+1. Solution: Provide a more informative loggings when we encounter a CRC mismatch and also output the mon versions so it's easier for us to detect which if the crc mismatch comes from OSDMap running mixed versions or not. Fixes: https://tracker.ceph.com/issues/63389 Signed-off-by: Kamoltat <ksirivad@redhat.com>
ljflores
approved these changes
Dec 15, 2023
rzarzynski
approved these changes
Dec 18, 2023
| derr << __func__ << " full map CRC mismatch, resetting to canonical" | ||
| << dendl; | ||
| derr << __func__ << " full map CRC mismatch," | ||
| << " might be because mons are running mixed versions ..." |
There was a problem hiding this comment.
nit: just formatting (tabs / spaces).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When mons are running different versions, e.g.,
during upgrades, we sometimes will encounter a crc mismatch between the crc that is generated
from the leader MON (version n+1) and
the peon MON (version n). Which will
later then gets resolved when all the MONs
are at version n+1.
Solution:
Provide a more informative loggings when
we encounter a CRC mismatch and also
output the mon versions so it's easier
for us to detect which if the crc mismatch
comes from OSDMap running mixed versions or
not.
Fixes: https://tracker.ceph.com/issues/63389
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e