mgr: integrate optracker in ceph-mgr #54979

pdvian · 2023-12-21T07:05:01Z

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows
jenkins test rook e2e

pdvian · 2023-12-21T07:10:00Z

The commit-id 77891f9 introduces the basic optracker framework for mgr daemon. Let's discuss if it needs improvements. Also we need to discuss plan to define new op events accordingly and also how to leverage the optracking mechanism to mgr python modules.

rzarzynski

First round of review done. Looks sane! just a bunch of nits.

src/common/options/global.yaml.in

src/mgr/DaemonServer.cc

src/mgr/Mgr.h

src/mgr/MgrOpRequest.cc

src/mgr/MgrOpRequest.h

pdvian

Rest of the changes looks good to me except Radek's new review comments. Also squash the changes to single commit. Thank you!

src/common/options/global.yaml.in

rzarzynski

LGTM!

src/mgr/DaemonServer.cc

src/mgr/MgrOpRequest.cc

src/mgr/CMakeLists.txt

pdvian · 2024-03-14T23:19:10Z

jenkins test make check

rzarzynski · 2024-03-18T15:06:50Z

Oops, might be related:

The following tests FAILED:
	 37 - unittest_admin_socket (Failed)

rzarzynski · 2024-03-18T15:06:58Z

jenkins test make check

pdvian · 2024-03-20T22:08:44Z

jenkins test make check

src/mgr/DaemonServer.cc

pdvian · 2024-03-22T00:55:29Z

@rzarzynski @linuxkidd Need final review of this PR.

rzarzynski

It looks there is some duplication of op_tracker instances. Commented on that below.

src/common/options/global.yaml.in

src/mgr/DaemonServer.cc

src/mgr/DaemonServer.h

rzarzynski · 2024-03-22T19:50:32Z

src/mgr/Mgr.h

@@ -70,6 +71,10 @@ class Mgr : public AdminSocketHook {
  bool initialized;
  bool initializing;

+private:
+  // -- op tracking --
+  OpTracker op_tracker;


Hmm, the two op_tracker are both instances.

src/mgr/DaemonServer.cc

ljflores · 2024-03-25T20:41:43Z

Removing "needs-qa" since it looks like there are some additional things that need to be addressed. @pdvian feel free to re-add it when you want!

Signed-off-by: Prashant D <pdhange@redhat.com> Signed-off-by: Michael J. Kidd <linuxkidd@gmail.com>

pdvian · 2024-03-25T21:12:59Z

It looks there is some duplication of op_tracker instances. Commented on that below.

Removed duplicate op_tracker from Mgr and re-pushed the changes.

pdvian · 2024-03-25T21:14:37Z

Removing "needs-qa" since it looks like there are some additional things that need to be addressed. @pdvian feel free to re-add it when you want!

I have addressed the latest review comments. Kindly add this PR in next RADOS suite teuthology batch run.

rzarzynski · 2024-03-26T16:06:59Z

jenkins retest this please

rzarzynski · 2024-03-27T11:19:07Z

Traceback (most recent call last):
  File "/home/jenkins-build/build/workspace/ceph-api/build/../qa/tasks/vstart_runner.py", line 1546, in 
    exec_test()
  File "/home/jenkins-build/build/workspace/ceph-api/build/../qa/tasks/vstart_runner.py", line 1396, in exec_test
    remote.run(args=args, env=vstart_env, timeout=(3 * 60))
  File "/home/jenkins-build/build/workspace/ceph-api/build/../qa/tasks/vstart_runner.py", line 452, in run
    return self._do_run(**kwargs)
  File "/home/jenkins-build/build/workspace/ceph-api/build/../qa/tasks/vstart_runner.py", line 491, in _do_run
    proc.wait()
  File "/home/jenkins-build/build/workspace/ceph-api/build/../qa/tasks/vstart_runner.py", line 265, in wait
    raise CommandFailedError(self.args, self.exitstatus)
teuthology.exceptions.CommandFailedError: Command failed with status 1: '../src/vstart.sh -n --nolockdep'

rzarzynski · 2024-03-27T11:19:39Z

jenkins test api

pdvian · 2024-04-02T16:24:34Z

jenkins test api

pdvian · 2024-04-04T18:13:26Z

ceph API tests succeeded, re-triggering make check job.

pdvian · 2024-04-04T18:13:31Z

jenkins test make check

rzarzynski · 2024-04-08T15:22:05Z

@ljflores, @pdvian: am I seeing correctly this PR is ready to go?

pdvian · 2024-04-22T17:06:19Z

@ljflores, @pdvian: am I seeing correctly this PR is ready to go?

Yes, I donot see any failures related to this PR in https://pulpito.ceph.com/?branch=wip-yuri8-testing-2024-03-25-1419.

Failure, unrelated :

cephadm: Health detail: HEALTH_WARN 1/3 mons down, quorum a,c in cluster log
cephadm: Health check failed: 1 osds down (OSD_DOWN) in cluster log
qa/standalone/scrub/osd-scrub-repair.sh: TEST_repair_stats_ec: test 26 = 13
cephadm: log_channel(cephadm) log [ERR] : Failed to connect to smithi090 (10.0.0.9). Permission denied
rados/thrash: AssertionError: wait_for_recovery: failed before timeout expired
cephadm/osds, cephadm/workunits: Health check failed: 1 pool(s) do not have an application enabled (POOL_APP_NOT_ENABLED) in cluster log
ceph_test_lazy_omap_stats segfault while waiting for active+clean
centos 9 testing reveals rocksdb "Leak_StillReachable" memory leak in mons
rados/cephadm/smoke: Health check failed: 1 stray daemon(s) not managed by cephadm (CEPHADM_STRAY_DAEMON) in cluster log

Details:

ljflores · 2024-04-23T22:49:00Z

It's rados approved! https://tracker.ceph.com/projects/rados/wiki/MAIN#httpstrackercephcomissues65126

pdvian added the DNM label Dec 21, 2023

pdvian requested review from rzarzynski, linuxkidd and neha-ojha December 21, 2023 07:05

pdvian requested a review from a team as a code owner December 21, 2023 07:05

github-actions bot added build/ops common core mgr labels Dec 21, 2023

rzarzynski added the feature label Jan 17, 2024

rzarzynski reviewed Jan 17, 2024

View reviewed changes

pdvian commented Jan 29, 2024

View reviewed changes

src/common/options/global.yaml.in Outdated Show resolved Hide resolved

linuxkidd force-pushed the wip-mgr-optracker branch 3 times, most recently from fc03f65 to cf43e8e Compare January 30, 2024 00:06

linuxkidd approved these changes Jan 30, 2024

View reviewed changes

rzarzynski approved these changes Jan 30, 2024

View reviewed changes

src/mgr/DaemonServer.cc Outdated Show resolved Hide resolved

src/mgr/MgrOpRequest.cc Show resolved Hide resolved

rzarzynski added needs-qa and removed DNM labels Jan 30, 2024

rzarzynski changed the title ~~[DNM] mgr: integrate optracker in ceph-mgr~~ mgr: integrate optracker in ceph-mgr Jan 30, 2024

yuriw added the wip-yuri6-testing label Jan 30, 2024

ljflores removed the wip-yuri6-testing label Feb 2, 2024

yuriw added wip-yuri4-testing and removed wip-yuri4-testing labels Feb 3, 2024

ljflores reviewed Feb 5, 2024

View reviewed changes

src/mgr/CMakeLists.txt Show resolved Hide resolved

ljflores added TESTED and removed needs-qa labels Feb 5, 2024

pdvian force-pushed the wip-mgr-optracker branch from cf43e8e to c256561 Compare February 5, 2024 18:32

pdvian added the wip-pdhange-testing1 label Feb 5, 2024

pdvian commented Mar 21, 2024

View reviewed changes

src/mgr/DaemonServer.cc Show resolved Hide resolved

pdvian commented Mar 22, 2024

View reviewed changes

src/mgr/DaemonServer.cc Show resolved Hide resolved

pdvian requested review from rzarzynski and linuxkidd March 22, 2024 00:54

linuxkidd approved these changes Mar 22, 2024

View reviewed changes

rzarzynski reviewed Mar 22, 2024

View reviewed changes

ljflores removed the needs-qa label Mar 25, 2024

mgr: integrate optracker in ceph-mgr

66efcaa

Signed-off-by: Prashant D <pdhange@redhat.com> Signed-off-by: Michael J. Kidd <linuxkidd@gmail.com>

pdvian force-pushed the wip-mgr-optracker branch from 5962ef2 to 66efcaa Compare March 25, 2024 21:04

pdvian added the needs-qa label Mar 25, 2024

yuriw added the wip-yuri8-testing label Mar 25, 2024

ljflores merged commit 43b8639 into ceph:main Apr 23, 2024
10 of 11 checks passed

pdvian mentioned this pull request May 9, 2024

squid: mgr: integrate optracker in ceph-mgr #57382

Open

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mgr: integrate optracker in ceph-mgr #54979

mgr: integrate optracker in ceph-mgr #54979

pdvian commented Dec 21, 2023 •

edited

pdvian commented Dec 21, 2023 •

edited

rzarzynski left a comment

pdvian left a comment •

edited

rzarzynski left a comment

pdvian commented Mar 14, 2024

rzarzynski commented Mar 18, 2024

rzarzynski commented Mar 18, 2024

pdvian commented Mar 20, 2024

pdvian commented Mar 22, 2024

rzarzynski left a comment

rzarzynski Mar 22, 2024

ljflores commented Mar 25, 2024

pdvian commented Mar 25, 2024 •

edited

pdvian commented Mar 25, 2024

rzarzynski commented Mar 26, 2024

rzarzynski commented Mar 27, 2024

rzarzynski commented Mar 27, 2024

pdvian commented Apr 2, 2024

pdvian commented Apr 4, 2024

pdvian commented Apr 4, 2024

rzarzynski commented Apr 8, 2024

pdvian commented Apr 22, 2024

ljflores commented Apr 23, 2024

mgr: integrate optracker in ceph-mgr #54979

mgr: integrate optracker in ceph-mgr #54979

Conversation

pdvian commented Dec 21, 2023 • edited

Contribution Guidelines

Checklist

pdvian commented Dec 21, 2023 • edited

rzarzynski left a comment

Choose a reason for hiding this comment

pdvian left a comment • edited

Choose a reason for hiding this comment

rzarzynski left a comment

Choose a reason for hiding this comment

pdvian commented Mar 14, 2024

rzarzynski commented Mar 18, 2024

rzarzynski commented Mar 18, 2024

pdvian commented Mar 20, 2024

pdvian commented Mar 22, 2024

rzarzynski left a comment

Choose a reason for hiding this comment

rzarzynski Mar 22, 2024

Choose a reason for hiding this comment

ljflores commented Mar 25, 2024

pdvian commented Mar 25, 2024 • edited

pdvian commented Mar 25, 2024

rzarzynski commented Mar 26, 2024

rzarzynski commented Mar 27, 2024

rzarzynski commented Mar 27, 2024

pdvian commented Apr 2, 2024

pdvian commented Apr 4, 2024

pdvian commented Apr 4, 2024

rzarzynski commented Apr 8, 2024

pdvian commented Apr 22, 2024

ljflores commented Apr 23, 2024

pdvian commented Dec 21, 2023 •

edited

pdvian commented Dec 21, 2023 •

edited

pdvian left a comment •

edited

pdvian commented Mar 25, 2024 •

edited