reef: librados: make querying pools for selfmanaged snaps reliable #55026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
idryomov
force-pushed
the
wip-63607-reef
branch
from
c1d2016
to
b3483a5
Compare
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
If get_pool_is_selfmanaged_snaps_mode() is invoked on a fresh RADOS client instance that still lacks an osdmap, it returns false, same as for "this pool is not in selfmanaged snaps mode". The same happens if the pool in question doesn't exist since the signature doesn't allow to return an error. The motivation for this API was to prevent users from running "rados cppool" on a pool with unmanaged snapshots and deleting the original thinking that they have a full copy. Unfortunately, it's exactly "rados cppool" that fell into this trap, so no warning is printed and --yes-i-really-mean-it flag isn't enforced. Fixes: https://tracker.ceph.com/issues/63607 Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit 0999e63) Conflicts: PendingReleaseNotes [ moved to >=18.2.2 section ]
Safeguards in rados CLI tool isn't really the subject of this test, but it fits nicely. Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit 2b135a2)
idryomov
force-pushed
the
wip-63607-reef
branch
from
b3483a5
to
af5fe53
Compare
|
Rebased to resolve a conflict in |
|
jenkins test make check |
rzarzynski
approved these changes
Feb 15, 2024
|
|
||
| /// check if pool has or had selfmanaged snaps | ||
| bool get_pool_is_selfmanaged_snaps_mode(const std::string& poolname) | ||
| __attribute__ ((deprecated)); |
There was a problem hiding this comment.
I assume it's fine to deprecate in a minor release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/63900
backport of #54644
parent tracker: https://tracker.ceph.com/issues/63607