pacific: mgr/BaseMgrModule: Optimize CPython Call in Finish Function #55109
Conversation
|
If this is a must for 16.2.15, please add it to https://github.com/ceph/ceph/milestone/17 since Pacific is going EOL. |
Only developers can edit labels and milestones, I'm not |
k0ste
force-pushed
the
wip-63978-pacific
branch
from
e63a900
to
d2ebeb3
Compare
|
This changeset wasn't staging in the main branch enough to observe long-term behavior. As the .15 is the last minor release of the series (pacific goes EOL), there won't be more time. Let's close it. |
|
Thanks for your contribution! |
|
Will see how this goes in testing since there is a little more time for 16.2.15. |
Remove CPython overhead packing tuple during the 'finish' function to improve memory consumption when we deal with long-string outputs. When modules like Restful return large amounts of output the use of PyObject_CallFunction without createing PyObject will reduce the time the memory held by the mgr. Fixes: https://tracker.ceph.com/issues/59580 Signed-off-by: Nitzan Mordechai <nmordech@redhat.com> (cherry picked from commit 247ace1)
k0ste
force-pushed
the
wip-63978-pacific
branch
from
d2ebeb3
to
910cd68
Compare
There was a problem hiding this comment.
Blocking merging until @rzarzynski and @NitzanMordhai can take a final look.
The rados suite passed though: https://tracker.ceph.com/projects/rados/wiki/PACIFIC#httpstrellocomcN8lquGmt1946-wip-yuri2-testing-2024-02-01-0939-pacific
looks good to me, although only 1 test was for the rest module, but it cover all options. @rzarzynski any thoughts? |
backport tracker: https://tracker.ceph.com/issues/63978
backport of #54634
parent tracker: https://tracker.ceph.com/issues/59580
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh