reef: mon/ConnectionTracker.cc: disregard connection scores from mon_rank = -1

[kamoltat]

There are certain situations where we would
come across rank -1 in our MON connection scores;

• New MON sends probe message to existing MON, existing MON handle probe message by adding -1
  to existing peer_scores.

This is not good because we want to implement
a connection scores check mechanism where we
should not have to take into account the possibility of having rank -1 in our score.

Fixes: https://tracker.ceph.com/issues/59564

Signed-off-by: Kamoltat ksirivad@redhat.com
(cherry picked from commit 6ffc70a)

Backporting relevant commits from main PR:

#52380

Contribution Guidelines

• To sign and title your commits, please refer to Submitting Patches to Ceph.

• If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

• When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

• Tracker (select at least one)
  • References tracker ticket
  • Very recent bug; references commit where it was introduced
  • New feature (ticket optional)
  • Doc update (no ticket needed)
  • Code cleanup (no ticket needed)
• Component impact
  • Affects Dashboard, opened tracker ticket
  • Affects Orchestrator, opened tracker ticket
  • No impact that needs to be tracked
• Documentation (select at least one)
  • Updates relevant documentation
  • No doc update is appropriate
• Tests (select at least one)
  • Includes unit test(s)
  • Includes integration test(s)
  • Includes bug reproducer
  • No tests

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test dashboard cephadm
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox
• jenkins test windows
• jenkins test rook e2e

[rzarzynski]

@ljflores, @yuriw: ping.

[Matan-B]

Rados Approved.

https://trello.com/c/LwEqRMyO/1932-wip-yuri-testing-2024-01-21-0805-reef-old-wip-yuri-testing-2024-01-18-0746-reef

7528677, 7528748, 7528951 - Heartbeat crash - Backport #63559: reef: Heartbeat crash in osd - RADOS - Ceph
7528714 - rbd/test_librbd_python.sh test failures - Bug #63941: rbd/test_librbd_python.sh test failures - rbd - Ceph
7528755 - do not have an application enabled - Bug #62776: rados: cluster [WRN] overall HEALTH_WARN - do not have an application enabled - RADOS - Ceph
7528813, 7528814, 7528882 - centos 9 "Leak_StillReachable" - Bug #61774: centos 9 testing reveals rocksdb "Leak_StillReachable" memory leak in mons - RADOS - Ceph

Infra:
7528792, 7528935 - Error: Container release squid != cephadm release reef;
7528866 - Error authenticating with smithi
7528752, 7528754, 7528775 - Error reimaging machines
7528777 - SSH connection to smithi196 was lost