install-deps: Force remove ceph-libboost* packages #55240
Conversation
As `apt-get remove ceph-libboost*` show the error and cause the make check failed. `E: The package ceph-libboost1.79-dev needs to be reinstalled, but I can't find an archive for it.` The ceph-libboost* packages may be not removed, so use `dpkg` to force remove ceph-libboost*. Fixes: https://tracker.ceph.com/issues/64032 Signed-off-by: luo rixin <luorixin@huawei.com>
|
@idryomov @adamemerson @cbodley ,please take a review, thanks |
There was a problem hiding this comment.
Did you verify that the error hit in https://tracker.ceph.com/issues/64032 is addressed by this change? If so, how?
| awk -F: '{print $1}') | ||
| if test -n "$ceph_libboost_pkgs"; then | ||
| ci_debug "Force remove ceph-libboost* packages $ceph_libboost_pkgs" | ||
| $SUDO dpkg --purge --force-all $ceph_libboost_pkgs |
There was a problem hiding this comment.
I'm not into packaging at all, but I'm wondering if both apt-get remove and dpkg --purge are needed. If dpkg --purge is stronger, perhaps we should just switch to it?
There was a problem hiding this comment.
apt-get remove can handle dependencies and remove the related softwares, It is more safe. In this case, we can just use dpkg --purge
Yes, the error packages can be force removed. |
|
interesting that
|
Yes, someone noted this awhile back. Would be good to fix this so the check is more meaningful. I added a ticket for that here: https://tracker.ceph.com/issues/64117 |
As
apt-get remove ceph-libboost*show the error and cause the make check failed.E: The package ceph-libboost1.79-dev needs to be reinstalled, but I can't find an archive for it.The ceph-libboost* packages may be not removed, so usedpkgto force remove ceph-libboost*.Fixes: https://tracker.ceph.com/issues/64032
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e