Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: show some additional osd/pool stats on fsck completion. #55298

Merged
merged 1 commit into from
May 15, 2024

Conversation

ifed01
Copy link
Contributor

@ifed01 ifed01 commented Jan 24, 2024

Sometime we might want to learn actual OSD utilization by means alternative to regular stats reporting.
This patch enables such an accounting during fsck.
E.g. this could be helpful to investigate stats reporting discrepancies or something.
Relevant log output looks like the following:

... 2 bluestore(dev/osd0) _fsck_on_open Per-pool stats:
... 2 bluestore(dev/osd0) _fsck_on_open pool -1 -> (58 objects, 0 shared blobs, 278 omaps, 6798 bytes in omap keys, 52863 bytes in omap vals, 70038 bytes stored, 229376 bytes allocated)
... 2 bluestore(dev/osd0) _fsck_on_open pool 1 -> (3 objects, 0 shared blobs, 0 omaps, 0 bytes in omap keys, 0 bytes in omap vals, 459280 bytes stored, 462848 bytes allocated)
... 2 bluestore(dev/osd0) _fsck_on_open pool 2 -> (44 objects, 0 shared blobs, 0 omaps, 0 bytes in omap keys, 0 bytes in omap vals, 0 bytes stored, 0 bytes allocated)
... 1 bluestore(dev/osd0) _fsck_on_open <<<FINISH>>> with 0 errors, 0 warnings, 0 repaired, 0 remaining in 0.039815 seconds

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@ifed01 ifed01 requested a review from a team as a code owner January 24, 2024 12:13
@ifed01 ifed01 added feature and removed core labels Jan 24, 2024
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
@ifed01
Copy link
Contributor Author

ifed01 commented Jan 25, 2024

jenkins test make check

@ifed01
Copy link
Contributor Author

ifed01 commented Feb 18, 2024

jenkins test api

1 similar comment
@ifed01
Copy link
Contributor Author

ifed01 commented Feb 22, 2024

jenkins test api

Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Apr 22, 2024
@yuriw
Copy link
Contributor

yuriw commented May 3, 2024

This PR is under test in https://tracker.ceph.com/issues/65798.

@NitzanMordhai
Copy link
Contributor

@yuriw yuriw merged commit 02c7a4c into ceph:main May 15, 2024
11 checks passed
@ifed01 ifed01 deleted the wip-ifed-fsck-stats branch May 15, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants