os/bluestore: show some additional osd/pool stats on fsck completion. #55298
+100
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometime we might want to learn actual OSD utilization by means alternative to regular stats reporting.
This patch enables such an accounting during fsck.
E.g. this could be helpful to investigate stats reporting discrepancies or something.
Relevant log output looks like the following:
... 2 bluestore(dev/osd0) _fsck_on_open Per-pool stats:
... 2 bluestore(dev/osd0) _fsck_on_open pool -1 -> (58 objects, 0 shared blobs, 278 omaps, 6798 bytes in omap keys, 52863 bytes in omap vals, 70038 bytes stored, 229376 bytes allocated)
... 2 bluestore(dev/osd0) _fsck_on_open pool 1 -> (3 objects, 0 shared blobs, 0 omaps, 0 bytes in omap keys, 0 bytes in omap vals, 459280 bytes stored, 462848 bytes allocated)
... 2 bluestore(dev/osd0) _fsck_on_open pool 2 -> (44 objects, 0 shared blobs, 0 omaps, 0 bytes in omap keys, 0 bytes in omap vals, 0 bytes stored, 0 bytes allocated)
... 1 bluestore(dev/osd0) _fsck_on_open <<<FINISH>>> with 0 errors, 0 warnings, 0 repaired, 0 remaining in 0.039815 seconds
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
x
between the brackets:[x]
. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows
jenkins test rook e2e