Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Fixing RGW graph panels #55314

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

cloudbehl
Copy link
Contributor

  • Fixing grafana panels for rgw dashboards
  • Fixing RGW overview dashboard queries

fixes: https://tracker.ceph.com/issues/64177

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@cloudbehl cloudbehl requested a review from a team as a code owner January 25, 2024 13:07
@cloudbehl cloudbehl requested review from avanthakkar and afreen23 and removed request for a team January 25, 2024 13:07
@cloudbehl
Copy link
Contributor Author

Merge this PR after: #54623

@aaSharma14 can you help generate dashboard out folder?

- Fixing grafana panels for rgw dashboards
- Fixing RGW overview dashboard queries

fixes https://tracker.ceph.com/issues/64177

Signed-off-by: cloudbehl <cloudbehl@gmail.com>
@avanthakkar
Copy link
Contributor

jenkins retest this please

@aaSharma14
Copy link
Contributor

jenkins test make check

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
@nizamial09
Copy link
Member

jenkins test dashboard cephadm

1 similar comment
@avanthakkar
Copy link
Contributor

jenkins test dashboard cephadm

Copy link
Contributor

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brief look at code changes looks good! I'll setup a test cluster & verify if grafana dashboards are showing correct data.

@aaSharma14
Copy link
Contributor

jenkins test dashboard cephadm

3 similar comments
@aaSharma14
Copy link
Contributor

jenkins test dashboard cephadm

@cloudbehl
Copy link
Contributor Author

jenkins test dashboard cephadm

@cloudbehl
Copy link
Contributor Author

jenkins test dashboard cephadm

@aaSharma14 aaSharma14 merged commit a85baa8 into ceph:main Feb 13, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
4 participants