reef: mgr/dashboard: Create subvol of same name in different group #55369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes https://tracker.ceph.com/issues/64112 Issue: Currently, we are unable to create subvolume of same name in different subvolume group Fix: We are validating only the filesystem name of subvolume which is stopping the creation a subvolume of same name. Added more granularity , by adding the subvolumegroup name. Signed-off-by: Afreen <afreen23.git@gmail.com> (cherry picked from commit fb79df4)
afreen23
requested review from
aaSharma14 and
Pegonzal
and removed request for
a team
nizamial09
approved these changes
Jan 30, 2024
|
I just remembered that this alone might not be sufficient to fix the issue in reef. We will need the modification done in this file, which I'll soon backport to reef. Once that is backported, we can proceed with this PR. |
|
you won't believe this but I already backported everything 3 weeks ago: #55186 and then I forgot about doing it ever. So I blocked this PR for no reason at all :) |
|
jenkins test api |
|
jenkins test api |
|
jenkins test dashboard |
|
jenkins test dashboard cephadm |
1 similar comment
|
jenkins test dashboard cephadm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/64239
backport of #55349
parent tracker: https://tracker.ceph.com/issues/64112
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh