Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: enhance radoslist to allow object & object version to be specified #55456

Closed
wants to merge 1 commit into from

Conversation

ivancich
Copy link
Member

@ivancich ivancich commented Feb 5, 2024

Previously radosgw-admin bucket radoslist ... could be run with or without a --bucket specified. Either way, if only the information for a single object is desired, there will be a lot of unwanted extra information. So the command is enhanced to optionally allow --object and --object_version to be specified. Each does the obvious thing. For example, on a versioned bucket if --object is specified but --object_version is not, it will produce a list of rados objects for all versions.

Tracker: https://tracker.ceph.com/issues/64322

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

Previously `radosgw-admin bucket radoslist ...` could be run with or
without a --bucket specified. Either way, if only the information for
a single object is desired, there will be a lot of unwanted extra
information. So the command is enhanced to optionally allow --object
and --object_version to be specified. Each does the obvious thing. For
example, on a versioned bucket if --object is specified but
--object_version is not, it will produce a list of rados objects for
*all* versions.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
@cbodley
Copy link
Contributor

cbodley commented Feb 5, 2024

does this still have to process the entire bucket? maybe it's better to add a separate command like object radoslist that just reads a given head object and dumps the objects from its manifest

@ivancich
Copy link
Member Author

ivancich commented Feb 5, 2024

does this still have to process the entire bucket? maybe it's better to add a separate command like object radoslist that just reads a given head object and dumps the objects from its manifest

That was my original thought, but then you suggested "maybe just add support for the --object argument to 'bucket radoslist'" and I realized it could handle a seemingly useful case of a versioned bucket where the user specifies the object name but not the version id.

I could imagine leaving this as is, and adding the other way as well, but perhaps including additional information, such as pool.

Copy link

github-actions bot commented Apr 5, 2024

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Apr 5, 2024
Copy link

github-actions bot commented May 5, 2024

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants