Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reef: mgr/prometheus: fix orch check to prevent Prometheus crash #55491

Merged
merged 1 commit into from Feb 8, 2024

Conversation

rkachach
Copy link
Contributor

@rkachach rkachach commented Feb 8, 2024

https://tracker.ceph.com/issues/64339

Backport of #55149

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@rkachach
Copy link
Contributor Author

rkachach commented Feb 8, 2024

jenkins test rook e2e

Copy link
Contributor

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avanthakkar
Copy link
Contributor

Btw backport of seems like another PR , shouldn't it be #55149 ?

@rkachach
Copy link
Contributor Author

rkachach commented Feb 8, 2024

Btw backport of seems like another PR , shouldn't it be #55149 ?

Yep, that's right. I fixed the link 👍

@rkachach rkachach merged commit 5c94ced into ceph:reef Feb 8, 2024
13 checks passed
@idryomov idryomov changed the title backport mgr/prometheus: fix orch check to prevent Prometheus crash reef: mgr/prometheus: fix orch check to prevent Prometheus crash Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants