osd: always send returnvec-on-errors for client's retry #55570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is a discrepancy in terms of the returnvec's presence between MOSDOpReplys sent for original requests and those on dups. The former always contain the returnvec if an error happened, even if `allows_returnvec()` is `false`. This commit extends the behavior on dups. For RCA please see: https://tracker.ceph.com/issues/64192#note-9 Fixes: https://tracker.ceph.com/issues/64192 Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
ljflores
approved these changes
Feb 14, 2024
idryomov
reviewed
Feb 14, 2024
| @@ -4288,8 +4288,11 @@ void PrimaryLogPG::execute_ctx(OpContext *ctx) | |||
| } | |||
| reply->add_flags(CEPH_OSD_FLAG_ACK | CEPH_OSD_FLAG_ONDISK); | |||
| // append to pg log for dup detection - don't save buffers for now | |||
There was a problem hiding this comment.
Is the "don't save buffers for now" bit still valid? It looks like it predates the introduction of RETURNVEC flag in 2019.
There was a problem hiding this comment.
Yes, it's still the same (by the buffers I understand e.g. a write op's payload).
There was a problem hiding this comment.
I interpreted it as write op's reply payload (i.e. out data). If you believe the comment to be valid, I withdraw ;)
|
Removing "needs-qa" until @idryomov's comment is addressed. |
|
@rzarzynski feel free to add needs-qa when you're ready |
|
Added the label, @ljflores! |
|
Looks like unrelated: |
|
jenkins test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a discrepancy in terms of the returnvec's presence between MOSDOpReplys sent for original requests and those on dups. The former always contain the returnvec if an error happened, even if
allows_returnvec()isfalse.This commit extends the behavior on dups.
For RCA please see: https://tracker.ceph.com/issues/64192#note-9
Fixes: https://tracker.ceph.com/issues/64192
Signed-off-by: Radoslaw Zarzynski rzarzyns@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e