pacific: rgw/putobj: RadosWriter uses part head object for multipart parts #55586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbodley
requested review from
ivoalmeida and
Pegonzal
and removed request for
a team
github-actions
bot
added
build/ops
ceph-volume
cephadm
cephfs
oops |
the cleanup logic in the RadosWrite destructor was using the wrong `head_obj` to avoid races between cleanup and part re-uploads. it pointed at the final location of the multipart upload, rather than the head object of the current part Fixes: https://tracker.ceph.com/issues/63642 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit bbbf5c5) Conflicts: rgw_putobj_processor.* uses sal::RGWObject instead of rgw_obj
cbodley
force-pushed
the
wip-64427-pacific
branch
from
17f501b
to
5a98f50
Compare
cbodley
requested review from
a team
and removed request for
a team,
ivoalmeida and
Pegonzal
cbodley
removed
documentation
core
rbd
cephfs
ivancich
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/64427
backport of #55582
parent tracker: https://tracker.ceph.com/issues/63642
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh