make ceph_test_rados / RadosModel validate the versions exposed by librados #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 28, 2013 17:05
The C++ AioCompletion::get_version() method only returns 32-bits. Sigh. Add a get_version64() method that returns all 64-bits. Do not touch the 32-bit version to avoid breaking the ABI. Backport: dumpling, cuttlefish Signed-off-by: Sage Weil <sage@inktank.com>
Presumbly a mismerge somewhere back around de20997. Signed-off-by: Sage Weil <sage@inktank.com>
Set the user version to the *current* object version, not the version we would use if we were to modify it. We move the assignments inside the reply (read or error) block to make it more obvious which paths are possible. Signed-off-by: Sage Weil <sage@inktank.com>
Signed-off-by: Sage Weil <sage@inktank.com>
|
Reviewed-by: |
|
Looks good to me |
liewegas
pushed a commit
that referenced
this pull request
Aug 29, 2013
make ceph_test_rados / RadosModel validate the versions exposed by librados Reviewed-by: Greg Farnum <greg@inktank.com> Reviewed-by: Samuel Just <sam.just@inktank.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.