Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logrotate: fix racecondition between rotate and compress #55662

Closed
wants to merge 1 commit into from

Conversation

mlausch
Copy link
Contributor

@mlausch mlausch commented Feb 20, 2024

sometimes ceph needs a bit longer to reopen it logfiles. This can cause the following logrotate error/warning

error: Compressing program wrote following message to stderr when compressing log /var/log/ceph/ceph-osd.1456.log-20240131:
gzip: stdin: file size changed while zipping

this is fixed with a delaycompress, so the logfile will compressed one day after rotating. This should be enough time for ceph to reopen its logfiles

Fixes: https://tracker.ceph.com/issues/58920
Signed-off-by: Manuel Lausch manuel.lausch@1und1.de

…se the following logrotate error/warning

error: Compressing program wrote following message to stderr when compressing log /var/log/ceph/ceph-osd.1456.log-20240131:
gzip: stdin: file size changed while zipping

this is fixed with a delaycompress, so the logfile will compressed one day after rotating. This should be enough time for ceph to reopen its logfiles

Fixes: https://tracker.ceph.com/issues/58920
Signed-off-by: Manuel Lausch <manuel.lausch@1und1.de>
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Apr 20, 2024
Copy link

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant