reef: librbd: fix split() for SparseExtent and SparseBufferlistExtent #55665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparseExtents and SparseBufferlist are typedefs for interval_map. In both cases, split() handler is broken: for the former the extent isn't actually split and for the latter incorrect bufferlist is attached to the split extent. Fortunately, both SnapshotDelta as produced by ObjectListSnapsRequest and SparseBufferlist used in a couple of places seem to be collections where only disjoint intervals are inserted and splitting doesn't occur (at least in the common case). But still, this is a landmine waiting for someone to step on it. Fixes: https://tracker.ceph.com/issues/64423 Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit 746cb28)
- pass left.length + right.length instead of bl.length() for consistency and to avoid circumventing the assert in SparseBufferlistExtent constructor - claim_append() takes an lvalue reference, no need to move - follow the pattern used in split() Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit 69c18cf)
ajarr
approved these changes
Feb 20, 2024
trociny
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/64462
backport of #55579
parent tracker: https://tracker.ceph.com/issues/64423