Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv/RocksDBStore: Configure compact-on-deletion for all CFs #55676

Merged
merged 1 commit into from
Mar 25, 2024
Merged

kv/RocksDBStore: Configure compact-on-deletion for all CFs #55676

merged 1 commit into from
Mar 25, 2024

Commits on Feb 25, 2024

  1. kv/RocksDBStore: Configure compact-on-deletion for all CFs 

    update_column_family_options() is called only for non-default CFs,
whereas load_rocksdb_options() sets options for all CFs, including
default. This isn't really a problem for new installs, where the default
CF isn't used for very much, but for upgrades where resharding has not
yet happened, the bulk of rocksdb data is still in the default CF and so
it's important that it also gets compact-on-deletion configured, if
desired.

Fixes: https://tracker.ceph.com/issues/64511
Signed-off-by: Joshua Baergen <jbaergen@digitalocean.com>
    Joshua Baergen committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    e31c724 View commit details
    Browse the repository at this point in the history