Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crimson/osd/main: Enable multicore cluster messenger #55708

Merged
merged 2 commits into from Mar 11, 2024
Merged

crimson/osd/main: Enable multicore cluster messenger #55708

merged 2 commits into from Mar 11, 2024

Conversation

Matan-B
Copy link
Contributor

@Matan-B Matan-B commented Feb 22, 2024 •
edited

Taken from: f78e99c (Part 2/2 #52295)

Follow-up to: #55641

Drafted until tested.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@Matan-B @cyx1231st
@liu-chunmei @aisakaki
crimson/osd/main: Enable multicore cluster messenger
ab239ad 
Taken from: f78e99c

Co-authored-by: Yingxin Cheng <yingxin.cheng@intel.com>
Co-authored-by: Chunmei Liu <chunmei.liu@intel.com>
Co-authored-by: Xinyu Huang <xinyu.huang@intel.com>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@cyx1231st cyx1231st self-requested a review February 28, 2024 08:31
@Matan-B Matan-B marked this pull request as ready for review March 4, 2024 08:27
@Matan-B Matan-B requested a review from a team as a code owner March 4, 2024 08:27
@cyx1231st
Copy link
Member

Added a label ^, should be related.

@Matan-B
Copy link
Contributor Author

Matan-B commented Mar 6, 2024

https://shaman.ceph.com/builds/ceph/wip-matanb-crimson-cluster-msgr-testing

@Matan-B
crimson/osd/osd: handle_scrub_message on any core
cbad3e4 
After enabling multicore cluster messenger, there is no
guarantee which core will handle the request.
See: OSDSingletonState::send_to_osd()

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
Copy link
Contributor Author

Matan-B commented Mar 10, 2024

Results [1] look good after removing the assertion in the second commit.
IIUC, this should be ok to handle the request from any core and not only from the primary core.
However, the request should be handled from the primary OSD of the PG.
@athanatos

[1] https://pulpito.ceph.com/matan-2024-03-10_10:35:56-crimson-rados-wip-matanb-crimson-cluster-msgr-testing-distro-crimson-smithi/

@Matan-B Matan-B requested a review from athanatos March 10, 2024 12:22
@athanatos
Copy link
Contributor

Results [1] look good after removing the assertion in the second commit. IIUC, this should be ok to handle the request from any core and not only from the primary core. However, the request should be handled from the primary OSD of the PG. @athanatos

[1] https://pulpito.ceph.com/matan-2024-03-10_10:35:56-crimson-rados-wip-matanb-crimson-cluster-msgr-testing-distro-crimson-smithi/

The primary-osd constraint isn't relevant here -- it's taken care of otherwise. Removing this assert as you have done here should be sufficient.

@Matan-B
Copy link
Contributor Author

Matan-B commented Mar 11, 2024

jenkins test api

@Matan-B
Copy link
Contributor Author

Matan-B commented Mar 11, 2024

jenkins test make check

@Matan-B Matan-B merged commit c1ea979 into ceph:main Mar 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyx1231st cyx1231st cyx1231st approved these changes

@liu-chunmei liu-chunmei liu-chunmei approved these changes

@athanatos athanatos Awaiting requested review from athanatos

Assignees
No one assigned
Labels
crimson crimson-perf ready-to-merge TESTED wip-matan-testing
Projects
None yet
Milestone
No milestone
4 participants
@Matan-B @cyx1231st @athanatos @liu-chunmei