Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squid: rgw: RGWSI_SysObj_Cache::remove() invalidates after successful delete #55715

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

cbodley
Copy link
Contributor

@cbodley cbodley commented Feb 22, 2024

backport tracker: https://tracker.ceph.com/issues/64541


backport of #55634
parent tracker: https://tracker.ceph.com/issues/64480

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

invalidating the cache before the librados delete means that a racing call
to `RGWSI_SysObj_Cache::read()` may succeed and repopulate the cache. in
that case, subsequent reads will continue to return cached data even after
the librados delete succeeds

Fixes: https://tracker.ceph.com/issues/64480

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 0eebbc3)
@cbodley cbodley requested a review from a team as a code owner February 22, 2024 16:40
@cbodley cbodley added this to the squid milestone Feb 22, 2024
@cbodley cbodley added the rgw label Feb 22, 2024
@cbodley
Copy link
Contributor Author

cbodley commented Feb 28, 2024

@cbodley
Copy link
Contributor Author

cbodley commented Feb 28, 2024

jenkins test api

@cbodley
Copy link
Contributor Author

cbodley commented Feb 28, 2024

ERROR: test_list_enabled_module (tasks.mgr.dashboard.test_mgr_module.MgrModuleTest)

tracked in https://tracker.ceph.com/issues/62972

@cbodley
Copy link
Contributor Author

cbodley commented Feb 28, 2024

jenkins test api

1 similar comment
@cbodley
Copy link
Contributor Author

cbodley commented Feb 28, 2024

jenkins test api

@cbodley
Copy link
Contributor Author

cbodley commented Feb 29, 2024

teuthology.exceptions.CommandFailedError: Command failed with status 1: '../src/vstart.sh -n --nolockdep'

@cbodley
Copy link
Contributor Author

cbodley commented Feb 29, 2024

jenkins test api

@cbodley
Copy link
Contributor Author

cbodley commented Feb 29, 2024

No problems were identified. If you know why this problem occurred, please add a suitable Cause for it.

@cbodley
Copy link
Contributor Author

cbodley commented Feb 29, 2024

jenkins test api

@cbodley
Copy link
Contributor Author

cbodley commented Feb 29, 2024

ERROR: test_change_password (tasks.mgr.dashboard.test_user.UserTest)

@cbodley
Copy link
Contributor Author

cbodley commented Feb 29, 2024

jenkins test api

1 similar comment
@cbodley
Copy link
Contributor Author

cbodley commented Mar 8, 2024

jenkins test api

@cbodley cbodley merged commit 9e0ae02 into ceph:squid Mar 15, 2024
10 checks passed
@cbodley cbodley deleted the wip-64541-squid branch March 15, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants