quincy: rgw: RGWSI_SysObj_Cache::remove() invalidates after successful delete #55718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invalidating the cache before the librados delete means that a racing call to `RGWSI_SysObj_Cache::read()` may succeed and repopulate the cache. in that case, subsequent reads will continue to return cached data even after the librados delete succeeds Fixes: https://tracker.ceph.com/issues/64480 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 0eebbc3) Conflicts: RGWSysObjectCtxBase argument not present on reef/squid src/rgw/services/svc_sys_obj_cache.cc
dang
approved these changes
Feb 26, 2024
|
This PR is under test in https://tracker.ceph.com/issues/65558. |
|
This PR is under test in https://tracker.ceph.com/issues/65561. |
|
jenkins test make check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/64539
backport of #55634
parent tracker: https://tracker.ceph.com/issues/64480
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh