Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mon/OSDMonitor: fix rmsnap command #55841

Merged
merged 2 commits into from Mar 20, 2024
Merged

mon/OSDMonitor: fix rmsnap command #55841

merged 2 commits into from Mar 20, 2024

Conversation

Matan-B
Copy link
Contributor

@Matan-B Matan-B commented Feb 29, 2024 •
edited 

There are 2 ways to remove pool snaps, rados tool or mon command (ceph osd pool rmsnap).
It seems that the monitor command is not reporting the actual removal via new_removed_snaps which is later proceed in OSDMap::apply_incremental.
This will result in a clone object leakage since the snap id won't be marked as purged (and won't be trimmed).

Fixes: https://tracker.ceph.com/issues/64646

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@Matan-B
mon/OSDMonitor: fix rmsnap command
f19ad23 
```
There are 2 ways to remove pool snaps, rados tool or mon command (ceph osd pool rmsnap).
It seems that the monitor command is not reporting the actual removal via new_removed_snaps which is later proceed in OSDMap::apply_incremental.
This will result in a clone object leakage since the snap id won't be marked as purged (and won't be trimmed).
```

Fixes: https://tracker.ceph.com/issues/64646

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B requested a review from a team as a code owner February 29, 2024 14:48
@athanatos
Copy link
Contributor

It's probably worth adding comments at both sites noting that they are related. Even better would be moving that logic into a helper to be called from both places...

@Matan-B
mon/OSDMonitor: unify remove_pool_snap callers
70c1d79 
No changes in behavior.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B added the bug-fix label Mar 3, 2024
@Matan-B
Copy link
Contributor Author

Matan-B commented Mar 3, 2024 •
edited

It's probably worth adding comments at both sites noting that they are related. Even better would be moving that logic into a helper to be called from both places...

@athanatos, Fixed.

#53545 should help with the handling the leak.

@NitzanMordhai
Copy link
Contributor

rados approved https://tracker.ceph.com/projects/rados/wiki/MAIN#httpstrellocomcD8hvbaRe1974-wip-yuri7-testing-2024-03-14-0836-old-wip-yuri7-testing-2024-03-11-1229

@yuriw yuriw merged commit c1e6f35 into ceph:main Mar 20, 2024
11 checks passed
This was referenced Mar 24, 2024
Merged
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athanatos athanatos athanatos approved these changes

@rzarzynski rzarzynski rzarzynski approved these changes

Assignees
No one assigned
Labels
bug-fix core mon needs-qa wip-yuri7-testing
Projects
None yet
Milestone
No milestone
6 participants
@Matan-B @athanatos @NitzanMordhai @rzarzynski @yuriw @ljflores