mon,osd: use GMT time for the object name of hitsets #5585
Conversation
|
was #4941 |
|
would it make sense to allow 'ceph osd pool set $pool use_gmt_hitset' when hit_set_count == 0? |
@liewegas actually, thanks to the granularity of |
|
s/gmt/utc/ ? |
|
@liewegas gmt might be more helpful for the reader, as we are basically switching to + if (using_gmt) {
+ start.gmtime(ss) << "_";
+ end.gmtime(ss);
+ } else {
+ start.localtime(ss) << "_";
+ end.localtime(ss);
+ } |
| assert(osdmap.get_num_up_osds() == 0 || | ||
| osdmap.get_up_osd_features() & CEPH_FEATURE_OSD_HITSET_GMT); | ||
| if (!(m->osd_features & CEPH_FEATURE_OSD_HITSET_GMT)) { | ||
| dout(0) << __func__ << " conf requires 'osd hitset gmt' but osd at " |
There was a problem hiding this comment.
"one or more pools uses GMT hitsets but ..." ? it's not the conf we're checking here
|
aside from that warning msg nit, lgtm! Reviewed-by:. add needs-qa? |
|
updated the warning message as suggested by @liewegas and repushed. |
|
needs to run upgrade suite from hammer when doing cache/tiering |
|
the test added at https://github.com/ceph/ceph-qa-suite/tree/wip-tiering-hammer-x , will test it tomorrow. |
|
scratch that, [0] tchaikov@3893a1e#diff-33b7fd478ccf759677a0e515638a9a81R67 |
|
rebased against master to resolve merge conflicts and repushed. |
|
rebased & repushed |
|
Final thought.. if we think there is any possibility we'll backport this feature to hammer then we should not reuse the hobj sort feature bit... @athanatos ? |
|
rebased against master to fix the build failure |
|
passed my wip-sage-testing run, sage-2015-08-21_04:15:01-rados-wip-sage-testing-distro-basic-multi |
* bump the encoding version of pg_hit_set_info_t to 2, so we can tell if the corresponding hit_set is named using localtime or GMT * bump the encoding version of pg_pool_t to 20, so we can know if a pool is using GMT to name the hit_set archive or not. and we can tell if current cluster allows OSDs not support GMT mode or not. * add an option named `osd_pool_use_gmt_hitset`. if enabled, the cluster will try to use GMT mode when creating a new pool if all the the up OSDs support GMT mode. if any of the pools in the cluster is using GMT mode, then only OSDs supporting GMT mode are allowed to join the cluster. Fixes: ceph#9732 Signed-off-by: Kefu Chai <kchai@redhat.com>
allow "ceph osd pool set $pool use_gmt_hitset <true|1>" as long as the cluster supports gmt hitset. Fixes: ceph#9732 Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
* we do not persist current hit set using get_hit_set_current_object() anymore, instead we always append current hitset into archive even !hitset.is_full(), see fbd9c15. so it's not necessary to remove the current hitset object before putting it to disk. Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
|
fixed the compat version of |
mon,osd: use GMT time for the object name of hitsets Reviewed-by: Sage Weil <sage@redhat.com>
http://tracker.ceph.com/issues/9732 Fixes: #9732