reef: mon/OSDMonitor: fix get_min_last_epoch_clean() #55867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, an OSD marked out could have been added back to the map upon new beacon sent by the OSD. If the OSD goes down (after being added back to map) - it won't be marked as OUT again. Therefore, `osd_epochs` would remain with a "stale" OSD, as a result OSDMonitor::get_min_last_epoch_clean() will always return the "stale" OSD epoch. When osd is marked out, it will be erased from `osd_epochs` map. Correspondingly, it should be added back to the map **only** once it's marked in. Fixes: https://tracker.ceph.com/issues/63883 Signed-off-by: Matan Breizman <mbreizma@redhat.com> (cherry picked from commit dd1d30b)
Signed-off-by: Matan Breizman <mbreizma@redhat.com> (cherry picked from commit 1f89b68)
OUT OSDs can be the primary for a PG via pg_temp. Therfore, we should consider OUT as valid beacons. Signed-off-by: Matan Breizman <mbreizma@redhat.com> (cherry picked from commit ba750f4)
Co-authored-by: Samuel Just <sjust@redhat.com> Signed-off-by: Matan Breizman <mbreizma@redhat.com> (cherry picked from commit 685047b)
Matan-B
approved these changes
Mar 3, 2024
rzarzynski
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/64650
backport of #54999
parent tracker: https://tracker.ceph.com/issues/63883
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh