Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/seastar: update seastar submodule to fix FTBFS #55897

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

Matan-B
Copy link
Contributor

@Matan-B Matan-B commented Mar 3, 2024

See issue: ceph/seastar@d382f24
Submodule branch: https://github.com/ceph/seastar/tree/wip-matanb-seastar-sub-march24

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@Matan-B Matan-B requested review from tchaikov, athanatos and a team March 3, 2024 09:53
Matan-B referenced this pull request in ceph/seastar Mar 3, 2024
See: scylladb#1918

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B added the crimson label Mar 3, 2024
@Matan-B Matan-B force-pushed the wip-matanb-crimson-seastar-sub-march24 branch from ec0a3ae to 930a128 Compare March 3, 2024 10:39
See: ceph/seastar@d382f24

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B force-pushed the wip-matanb-crimson-seastar-sub-march24 branch from 930a128 to 945b181 Compare March 3, 2024 13:36
Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am not thrilled at seeing the "Broken?" -- it could be improved a little bit. but this change is an improvement, and unblocks #55886. so i'm approving it.

@tchaikov tchaikov merged commit 1a1fd80 into ceph:main Mar 4, 2024
11 checks passed
Copy link
Contributor

@idryomov idryomov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this should also be backported to squid after #55907 lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants