common: fix string creation from '0' in LogEntry

[ronen-fr]

C++23 disallows conversion from 'int' to 'string'.

That includes returning '0' from a function that returns a string.

[ronen-fr]

jenkins test make check

[tchaikov]

thanks. lgtm.

[tchaikov]

tests/test_host.py .F

_______________________ HostControllerTest.test_add_host _______________________

self = <dashboard.tests.test_host.HostControllerTest testMethod=test_add_host>
mock_add_host = <MagicMock name='add_host' id='140354858718240'>

    @mock.patch('dashboard.controllers.host.add_host')
    def test_add_host(self, mock_add_host):
        with patch_orch(True):
            payload = {
                'hostname': 'node0',
                'addr': '192.0.2.0',
                'labels': 'mon',
                'status': 'maintenance'
            }
            self._post(self.URL_HOST, payload, version=APIVersion(0, 1))
>           self.assertStatus(201)

tests/test_host.py:289: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
.tox/py3/lib/python3.10/site-packages/cheroot/test/webtest.py:323: in assertStatus
    self._handlewebError(msg)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <dashboard.tests.test_host.HostControllerTest testMethod=test_add_host>
msg = 'Status 400 Bad Request does not match 201'

    def _handlewebError(self, msg):  # noqa: C901  # FIXME
        print('')
        print('    ERROR: %s' % msg)
    
        if not self.interactive:
>           raise self.failureException(msg)
E           AssertionError: Status 400 Bad Request does not match 201

[tchaikov]

jenkins test make check

[ronen-fr]

jenkins test make check

[tchaikov]

change in a dead-end branch -- so no need to test with teuthology. i am merging it to unblock #55886

[ronen-fr]

change in a dead-end branch -- so no need to test with teuthology. i am merging it to unblock #55886

@tchaikov - I've just finished a successful round of Teuthology tests...

[tchaikov]

thanks for testing it. even better =)