Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Disable QAT on aarch64 #55980

Closed
wants to merge 1 commit into from
Closed

Conversation

Svelar
Copy link
Member

@Svelar Svelar commented Mar 6, 2024

build: Disable QAT on aarch64

QAT is intel-specific, it seems like reasonable that disable it on aarch64.

Fixes: https://tracker.ceph.com/issues/64678

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
@tchaikov
Copy link
Contributor

tchaikov commented Mar 6, 2024

please add the rationales in the commit message.

@Svelar
Copy link
Member Author

Svelar commented Mar 6, 2024

jenkins test api

@Svelar Svelar changed the title build: disable qat on aarch64 build: Disable QAT on aarch64 Mar 6, 2024
Copy link

github-actions bot commented Mar 6, 2024

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

Copy link
Contributor

@idryomov idryomov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was done more generally in #56000. Should this PR be closed?

@Svelar
Copy link
Member Author

Svelar commented Mar 25, 2024

Looks like it was done more generally in #56000. Should this PR be closed?

Yes, closed now.

@Svelar Svelar closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants