Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reef: mds: add a command to dump directory information #55987

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

joscollin
Copy link
Member

@joscollin joscollin commented Mar 6, 2024

Backported: #49756
Fixes: https://tracker.ceph.com/issues/64743

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

zhsgao and others added 3 commits March 6, 2024 15:05
Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>
(cherry picked from commit 42492d5)
Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>
(cherry picked from commit d4438d3)
Example output:
$ ceph daemon mds.a dump dir /test-dir
[
    {
        "value/bits": "0/0",
        "status": "dirfrag not in cache"
    }
]

Fixes: https://tracker.ceph.com/issues/63093
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit 5fb2f98)
@github-actions github-actions bot added cephfs Ceph File System tests labels Mar 6, 2024
@github-actions github-actions bot added this to the reef milestone Mar 6, 2024
@vshankar vshankar modified the milestones: reef, v18.2.2 Mar 6, 2024
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this go from one commit [1] to three?

https://github.com/ceph/ceph/pull/54202/commits

There must be an explanation in the PR description.

@batrick
Copy link
Member

batrick commented Mar 15, 2024

@joscollin
Copy link
Member Author

How did this go from one commit [1] to three?

https://github.com/ceph/ceph/pull/54202/commits

There must be an explanation in the PR description.

There's no tracker for the parent PR. So updated the PR url in the description.

Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vshankar vshankar requested a review from batrick March 19, 2024 14:52
@vshankar
Copy link
Contributor

@batrick re-requested a review from you. The original change was not a backport candidate. On request from some community members, it was picked up for backporting. Should have had a tracker created at that point. It's not late to do so right now though. WDYT?

@yuriw
Copy link
Contributor

yuriw commented Mar 20, 2024

@joscollin pls merge when ready
ref: https://trello.com/c/mF32rpDn

@joscollin
Copy link
Member Author

@joscollin pls merge when ready ref: https://trello.com/c/mF32rpDn

@vshankar FYI^

@vshankar vshankar dismissed batrick’s stale review March 26, 2024 09:29

PR description updated.

@vshankar vshankar merged commit 40b25e5 into ceph:reef Mar 26, 2024
16 checks passed
@joscollin joscollin deleted the wip-64743-reef branch March 26, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants