Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squid: rgw_sigv4: handle '0;' as trailer-chunk boundary #56036

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

cbodley
Copy link
Contributor

@cbodley cbodley commented Mar 7, 2024

backport tracker: https://tracker.ceph.com/issues/64768


backport of #55895
parent tracker: https://tracker.ceph.com/issues/64676

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

https://tracker.ceph.com/issues/64676

Signed-off-by: matt benjamin <mbenjamin@redhat.com>
(cherry picked from commit ef1111a)
@cbodley cbodley requested a review from a team as a code owner March 7, 2024 13:58
@cbodley cbodley added this to the squid milestone Mar 7, 2024
Copy link
Contributor

@mattbenjamin mattbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks identical to me

@cbodley
Copy link
Contributor Author

cbodley commented Mar 11, 2024

saw a java test failure in a batch that included this and #55871

2024-03-10T16:40:31.654 INFO:teuthology.orchestra.run.smithi060.stdout:suite > Object tests > ObjectTest.testObjectCreateBadExpectMismatch STARTED
2024-03-10T16:40:32.455 INFO:teuthology.orchestra.run.smithi060.stdout:
2024-03-10T16:40:32.455 INFO:teuthology.orchestra.run.smithi060.stdout:suite > Object tests > ObjectTest.testObjectCreateBadExpectMismatch FAILED
2024-03-10T16:40:32.455 INFO:teuthology.orchestra.run.smithi060.stdout:    com.amazonaws.services.s3.model.AmazonS3Exception at ObjectTest.java:525

i opened https://tracker.ceph.com/issues/64841 with a little more analysis

@cbodley
Copy link
Contributor Author

cbodley commented Mar 11, 2024

i see that the tests set boolean useV4Signature = false; for all of these ObjectTest cases, and confirmed that the requests are using sigv2 Authorization headers. so while strange, it's surely unrelated to these changes

@cbodley
Copy link
Contributor Author

cbodley commented Mar 11, 2024

jenkins test this please

@cbodley
Copy link
Contributor Author

cbodley commented Mar 11, 2024

@cbodley
Copy link
Contributor Author

cbodley commented Mar 11, 2024

/home/jenkins-build/build/workspace/ceph-pull-requests/build/src/seastar/gen/src/proto/metrics2.pb.h:17:2: error: This file was generated by an older version of protoc which is
#error This file was generated by an older version of protoc which is
^

@cbodley
Copy link
Contributor Author

cbodley commented Mar 11, 2024

jenkins test make check

@cbodley
Copy link
Contributor Author

cbodley commented Mar 12, 2024

The following tests FAILED:
7 - run-tox-mgr-dashboard-py3 (Failed)

@cbodley
Copy link
Contributor Author

cbodley commented Mar 12, 2024

jenkins test windows

@cbodley
Copy link
Contributor Author

cbodley commented Mar 12, 2024

jenkins test make check

@cbodley cbodley merged commit f6a7f60 into ceph:squid Mar 12, 2024
11 checks passed
@cbodley cbodley deleted the wip-64768-squid branch March 12, 2024 17:29
@bhinz
Copy link

bhinz commented Jun 3, 2024

Is there any roadmap to backport this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants